[CI] Add `kubectl kustomize` run to check our manifests definition

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 59 forks source link

[CI] Add `kubectl kustomize` run to check our manifests definition #545

Closed jstourac closed 4 months ago

jstourac commented 4 months ago

Added a simple check to CI to run kubectl kustomize so we are sure that our kustomization.yml files don't fail with an error. This should avoid issues like this in the future hopefully red-hat-data-services/notebooks#253.

This is tested automatically by this PR.

This should be backported to our downstream repo.

https://issues.redhat.com/browse/RHOAIENG-7886

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jiridanek commented 4 months ago

This job runs

---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy

I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?

openshift-ci[bot] commented 4 months ago

New changes are detected. LGTM label has been removed.

jstourac commented 4 months ago

This job runs
---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy
I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?

Probably we can, I'm not sure what else this change will cause. But I'm not gonna do it in this PR :slightly_smiling_face:

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@jstourac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	34bafd49f32d2e818bb510ade941ab55dd1957f9	link	true	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

jiridanek commented 4 months ago

This job runs
---
name: Code static analysis
on: [pull_request] # yamllint disable-line rule:truthy
I think that it should be push and pull_request, so that it's possible to test it on personal fork, before creating a PR. Wdyt?
Probably we can, I'm not sure what else this change will cause. But I'm not gonna do it in this PR 🙂

https://github.com/opendatahub-io/notebooks/pull/547

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment