Run the static code checks on push and when manually triggered

jiridanek commented 4 months ago

Description

GHA that only runs on pull_request is hard to test; I have to create PR to see it run. With this change, the action can be tested in my personal fork before I create a PR.

How Has This Been Tested?

I watched the GHA running, https://github.com/jiridanek/notebooks/actions/runs/9307359587/job/25618467398

The beauty of the morning; silent, bare, Ships, towers, domes, theaters, and temples lie Open unto the fields, and to the sky; All bright and glittering in the smokeless air.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jstourac commented 4 months ago

/lgtm

Thank you for this change!

atheo89 commented 4 months ago

/approve

I don't know why these prow tests got triggered. They shouldn't on this kind of PRs (ref)

/override ci/prow/images /override ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror /override ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror /override ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 4 months ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

In response to [this](https://github.com/opendatahub-io/notebooks/pull/547#issuecomment-2152833083): >/approve > >I don't know why these prow tests got triggered. They shouldn't on this kind of PRs ([ref](https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml#L683)) > >/override ci/prow/images >/override ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror >/override ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror >/override ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

opendatahub-io / notebooks