search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #553

Closed jiridanek closed 1 month ago

jiridanek commented 1 month ago

Jira: https://issues.redhat.com/browse/RHOAIENG-8255

Description

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

How Has This Been Tested?

Docker build succeeded

Merge criteria:

adelton commented 1 month ago

Technically that package exists there in koji ... but it is not signed there and koji is not really meant to be used by external production deployments. Per https://dl.fedoraproject.org/pub/fedora/linux/releases/37/README, https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/37/Everything/x86_64/os/Packages/s/spawn-fcgi-1.6.3-23.fc37.x86_64.rpm is likely the location to used.

But it is still a one-off build of the software which no longer receives security updates in Fedora (otherwise we would just used a fc40 build). Isn't this a chance to fix the issue properly, either finding different approach that spawn-fcgi, or assuming maintainership of it in EPEL, build it properly there, and use those builds?

jiridanek commented 1 month ago

https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/37/Everything/x86_64/os/Packages/s/spawn-fcgi-1.6.3-23.fc37.x86_64.rpm

Thanks for that, I was looking for it in "fedora archives" and I did not ctrl+f it under Packages/s/ myself. Not sure what I did wrong. Will use your link for sure!

atheo89 commented 1 month ago

/override ci/prow/images /override ci/prow/notebooks-e2e-tests

openshift-ci[bot] commented 1 month ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/553#issuecomment-2154722852): >/override ci/prow/images >/override ci/prow/notebooks-e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jiridanek commented 1 month ago

/cherrypick 2023b

openshift-cherrypick-robot commented 1 month ago

@jiridanek: new pull request created: #569

In response to [this](https://github.com/opendatahub-io/notebooks/pull/553#issuecomment-2173941649): >/cherrypick 2023b Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jiridanek commented 2 weeks ago

/cherrypick 2023a

openshift-cherrypick-robot commented 2 weeks ago

@jiridanek: new pull request created: #617

In response to [this](https://github.com/opendatahub-io/notebooks/pull/553#issuecomment-2225385939): >/cherrypick 2023a Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.