RHOAIENG-8299: Fix CentOS Stream 8 download location

jiridanek commented 4 months ago

https://issues.redhat.com/browse/RHOAIENG-8299

Description

Previously used location is now unavailable and returns 404 error. This is because CentOS Stream 8 has been EOLd

This new location is an archive and is no longer receiving updates.

How Has This Been Tested?

I thought about it really hard and I was very careful, promise. Oh yeah, and I did a podman image build, btw.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

atheo89 commented 4 months ago

The images built successfully! All set :)

/lgtm /approve

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

Regarding failing e2e tests. The intel image is a beast of almost 15GiB (compressed) and it downloads additional almost 400MiB of samples when it starts. It makes sense that it won't start up quickly, especially on our abused openshift-ci. My home net connection can't take such abuse and I had to switch to running this on a remote machine in Brno. I'll retrigger this a few more times and maybe I'll get lucky

[jdanek@localhost ~]$ podman images
REPOSITORY                                    TAG                                                                                                        IMAGE ID      CREATED       SIZE
ghcr.io/jiridanek/notebooks/workbench-images  jupyter-intel-tensorflow-ubi9-python-3.9-jd_try_dep_inside_nodes_fa89076788d08ff8f167626cfd78407fea720857  97b4d227d359  15 hours ago  14.4 GB

[jdanek@localhost ~]$ time podman run --net=host --rm -it ghcr.io/jiridanek/notebooks/workbench-images:jupyter-intel-tensorflow-ubi9-python-3.9-jd_try_dep_inside_nodes_fa89076788d08ff8f167626cfd78407fea720857
+ APP_ROOT=/opt/app-root
+ '[' -n https://github.com/IntelAI/oneAPI-samples ']'
++ echo https://github.com/IntelAI/oneAPI-samples
++ tr , ' '
+ for repo in `echo ${JUPYTER_PRELOAD_REPOS} | tr ',' ' '`
++ echo https://github.com/IntelAI/oneAPI-samples
++ cut -s -d@ -f2
+ REPO_BRANCH=
+ [[ -n '' ]]
+ echo 'Checking if repository https://github.com/IntelAI/oneAPI-samples exists locally'
Checking if repository https://github.com/IntelAI/oneAPI-samples exists locally
++ basename https://github.com/IntelAI/oneAPI-samples
+ REPO_DIR=oneAPI-samples
+ '[' -d oneAPI-samples ']'
+ GIT_SSL_NO_VERIFY=true
+ git clone https://github.com/IntelAI/oneAPI-samples oneAPI-samples
Cloning into 'oneAPI-samples'...
remote: Enumerating objects: 37899, done.
remote: Counting objects: 100% (1922/1922), done.
remote: Compressing objects: 100% (1073/1073), done.
remote: Total 37899 (delta 987), reused 1470 (delta 800), pack-reused 35977
Receiving objects: 100% (37899/37899), 390.30 MiB | 11.72 MiB/s, done.
Resolving deltas: 100% (24684/24684), done.
+ /opt/app-root/bin/start-notebook.sh

/retest

jiridanek commented 4 months ago

/test notebooks-e2e-tests

jiridanek commented 4 months ago

/test notebooks-e2e-tests

jiridanek commented 4 months ago

/test notebooks-e2e-tests

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest-required

jiridanek commented 4 months ago

/retest

jiridanek commented 4 months ago

/retest

atheo89 commented 3 months ago

/override ci/prow/notebooks-e2e-tests

as it is failing on intel notebook which is not related to habana

openshift-ci[bot] commented 3 months ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/554#issuecomment-2157707678): >/override ci/prow/notebooks-e2e-tests > >as it is failing on intel notebook which is not related to habana Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jstourac commented 3 months ago

@jiridanek @harshad16 don't we need this (or at least some parts of this) to backport also for the 2023b branch? :thinking:

jiridanek commented 3 months ago

/cherrypick 2023b

openshift-cherrypick-robot commented 3 months ago

@jiridanek: #554 failed to apply on top of branch "2023b":

Applying: RHOAIENG-8299: Fix CentOS Stream 8 download location
Using index info to reconstruct a base tree...
A   habana/1.13.0/ubi8-python-3.8/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): habana/1.13.0/ubi8-python-3.8/Dockerfile deleted in HEAD and modified in RHOAIENG-8299: Fix CentOS Stream 8 download location. Version RHOAIENG-8299: Fix CentOS Stream 8 download location of habana/1.13.0/ubi8-python-3.8/Dockerfile left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHOAIENG-8299: Fix CentOS Stream 8 download location
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/opendatahub-io/notebooks/pull/554#issuecomment-2173946488): >/cherrypick 2023b Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

atheo89 commented 2 months ago

/cherrypick 2023a

openshift-cherrypick-robot commented 2 months ago

@atheo89: #554 failed to apply on top of branch "2023a":

Applying: RHOAIENG-8299: Fix CentOS Stream 8 download location
Using index info to reconstruct a base tree...
A   habana/1.13.0/ubi8-python-3.8/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): habana/1.13.0/ubi8-python-3.8/Dockerfile deleted in HEAD and modified in RHOAIENG-8299: Fix CentOS Stream 8 download location. Version RHOAIENG-8299: Fix CentOS Stream 8 download location of habana/1.13.0/ubi8-python-3.8/Dockerfile left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHOAIENG-8299: Fix CentOS Stream 8 download location
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/opendatahub-io/notebooks/pull/554#issuecomment-2228024954): >/cherrypick 2023a Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

atheo89 commented 2 months ago

https://github.com/opendatahub-io/notebooks/pull/619 Fixed cherry pick PR for 2023a

opendatahub-io / notebooks