Setup build images for Pytorch & Tensorflow with base ROCm image

dibryant commented 1 month ago

Fixes for https://issues.redhat.com/browse/RHOAIENG-6377

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

atheo89 commented 1 month ago

Moreover, something that would be super useful for the PR review, but also as a complementary step to fulfill this work, is to set up the OCP-CI to build the newly created AMD PyTorch and TensorFlow notebooks.

jiridanek commented 1 month ago

Whoa, was wondering why the gha is failing, and it looks like it is running out of disk space

Total download size: 2.2 G
Installed size: 25 G
Downloading Packages:

Is it really necessary to install this much stuff? If yes, I'll get you more disk space tomorrow ;)

jiridanek commented 1 month ago

This ci fail is about missing lock file, https://github.com/opendatahub-io/notebooks/actions/runs/9600777904/job/26477839250?pr=557

jiridanek commented 1 month ago

Whoa, was wondering why the gha is failing, and it looks like it is running out of disk space

Here you go

https://github.com/opendatahub-io/notebooks/pull/577

openshift-ci[bot] commented 1 month ago

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebooks-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test notebooks-e2e-tests`
ci/prow/runtimes-ubi9-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test runtimes-ubi9-e2e-tests`
ci/prow/notebooks-ubi9-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test notebooks-ubi9-e2e-tests`
ci/prow/codeserver-notebook-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test codeserver-notebook-e2e-tests`
ci/prow/rstudio-notebook-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test rstudio-notebook-e2e-tests`
ci/prow/intel-notebooks-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test intel-notebooks-e2e-tests`
ci/prow/anaconda-ubi8-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test anaconda-ubi8-e2e-tests`
ci/prow/runtimes-ubi8-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test runtimes-ubi8-e2e-tests`
ci/prow/notebooks-ubi8-e2e-tests	27ac281bcb6f71b426529265290ba07467d6f3ff	link	true	`/test notebooks-ubi8-e2e-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

atheo89 commented 1 month ago

Adding this here as ref: https://github.com/openshift/release/pull/53309

harshad16 commented 1 month ago

This is look good to me i will be merging this for now.

The size is definitely as concern, we should take a deeper look at this. and try to see, if this can be reduced.

Thanks all for the review and great work on this. /lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

opendatahub-io / notebooks