jiridanek
commented
1 month ago Review comments history
I see on this draft that you affect only the DS notebook, but i see that GH runs the trusty and some others, do i miss something? https://github.com/opendatahub-io/notebooks/pull/555 stiill checking
actually, no, it is not nonsense, it truly is all images that 1) are at the end of the FROM: dependency chain and 2) they or one of the images in their FROM: chain is built in jupyter/datascience/ubi9-python-3.9 directory
for example, here's why it builds cuda; that cuda image builds in the jupyter/datascience/ubi9-python-3.9 directory
# Build and push cuda-jupyter-datascience-ubi9-python-3.9 image to the registry
.PHONY: cuda-jupyter-datascience-ubi9-python-3.9
cuda-jupyter-datascience-ubi9-python-3.9: cuda-jupyter-minimal-ubi9-python-3.9
$(call image,$@,jupyter/datascience/ubi9-python-3.9,$<)and here's why it builds trusty; trusty image depends on jupyter-datascience-ubi9-python-3.9
# Build and push jupyter-trustyai-ubi9-python-3.9 image to the registry
.PHONY: jupyter-trustyai-ubi9-python-3.9
jupyter-trustyai-ubi9-python-3.9: jupyter-datascience-ubi9-python-3.9
$(call image,$@,jupyter/trustyai/ubi9-python-3.9,$<)Since you affect the DS, I would expect to build the base, minimal and DS (base & minimal are prior DS on the build chain)
when it builds each of the three images, it does the full chain, so it starts from the base, https://github.com/opendatahub-io/notebooks/actions/runs/9498328161/job/26176822339?pr=555
It has to do the full chain because I don't have image registry write access available when building PRs on github actions
openshift-ci[bot]
atheo89
Description
Followup to
that filters out the list of images to build during a PR check only to those that have some source files changed.
This will speed up the PR check build.
How Has This Been Tested?
Created a draft PR that changes one file in a single docker image
Checked that it correctly builds all images that depend on this one.
Merge criteria: