opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #569

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #553

/assign jiridanek

openshift-ci[bot] commented 3 weeks ago

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 22b6f821b7df4b0c007867515af9f3779aa855f2 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/2023b/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstourac commented 3 weeks ago

Hey @harshad16 @jiridanek - didn't we miss this place? https://github.com/opendatahub-io/notebooks/blob/2023b/codeserver/c9s-python-3.9/Dockerfile#L41 :thinking: or don't we care?

jiridanek commented 3 weeks ago

I did grep for rpmfind in main, created or, later cherrypicked pr to 2023b. So probably this is some difference between branches? I'll be back porting the CentOS stream8 too, so I'll recheck all when doing that.

jstourac commented 3 weeks ago

yes, this is the difference in the branches

jiridanek commented 3 weeks ago

Created

to address the difference