opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 59 forks source link

[2024a] [CI] Enhance params env check script #575

Closed openshift-cherrypick-robot closed 3 months ago

openshift-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #567

/assign jiridanek

/cherrypick 2023b 2023a

openshift-ci[bot] commented 3 months ago

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jiridanek commented 3 months ago
Checking format of: 'odh-rstudio-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d'
Checking metadata for image 'odh-rstudio-notebook-image-n' with URL 'quay.io/opendatahub/workbench-images@sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d'
Image name retrieved: 'odh-notebook-rstudio-server-c9s-python-3.9'
Image created: '2024-05-23T17:16:00.755830268Z'
Image URL points to an incorrect image: expected OPENSHIFT_BUILD_NAME 'rstudio-c9s-python-3.9-amd64'; actual 'cuda-rstudio-c9s-python-3.9-amd64'
ERROR: Image definition for 'odh-rstudio-notebook-image-n' isn't okay!

https://github.com/opendatahub-io/notebooks/actions/runs/9587223228/job/26436804531?pr=575#step:4:102

jstourac commented 3 months ago

Yeah, IMHO the failure is genuine: https://quay.io/repository/opendatahub/workbench-images/manifest/sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d

harshad16 commented 3 months ago

Thanks for the wonderful PR /approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/2024a/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment