search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

Set Telemetry level off #576

Closed atheo89 closed 2 weeks ago

atheo89 commented 3 weeks ago

Related to: https://issues.redhat.com/browse/RHOAIENG-3348

Description

This PR set Telemetry off on code-server notebook.

How Has This Been Tested?

  1. Import the below image as custom notebook, with code-server-telemetry-off name on dashboard quay.io/opendatahub/workbench-images@sha256:3ea58b39357760cf7b35c0904ac15d303a2fabcebd6bf7c1211114dacef781bb
  2. Spin up the workbench that just imported (`code-server-telemetry-off``)
  3. Go to File -> Preferences -> settings ->search for telemetry -> check that the drop-down listbox is set to off the default value was all

Merge criteria:

atheo89 commented 3 weeks ago

Hey @jiridanek, can you reproduce the steps that you did at that time when you found that we had telemetry on, and check if we miss anything behind? So, far the only check that i did is to see if the elementary setting is off applied from .local/share/code-server/User/settings.json

jiridanek commented 2 weeks ago

Hey @jiridanek, can you reproduce the steps that you did at that time when you found that we had telemetry on, and check if we miss anything behind? So, far the only check that i did is to see if the elementary setting is off applied from .local/share/code-server/User/settings.json

Checked, I wrote the steps at https://issues.redhat.com/browse/RHOAIENG-3348. Looks good.

jiridanek commented 2 weeks ago

/retest-required

openshift-ci[bot] commented 2 weeks ago

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 1a6ebccffb5fa353268d1a675132b7872946663f link true /test notebooks-e2e-tests
ci/prow/intel-notebooks-e2e-tests 1a6ebccffb5fa353268d1a675132b7872946663f link true /test intel-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 weeks ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment