opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

Upgrade odh-elyra 3.16.7 for run_url update #578

Closed harshad16 closed 2 weeks ago

harshad16 commented 2 weeks ago

Upgrade odh-elyra 3.16.7 for run_url update https://github.com/opendatahub-io/elyra/releases/tag/3.16.7

Description

Set the run_url with experiment info included

The run_url is set in the format of: {experiment_id}/runs/{run_id} Example:

https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b

Related-to: https://issues.redhat.com/browse/RHOAIENG-8398

How Has This Been Tested?

This PR needs to be run with the compliment of the Dashboard Image: Use the following image: quay.io/opendatahub/odh-dashboard:main-a8d2118

  1. Set up a DS project
  2. Create a Data connection
  3. Create Pipeline configuration
  4. Use data-science notebook image create by this PR.
  5. Execute a Pipeline and check the RUN Details pointing to right pipeline run executed Screenshot from 2024-06-21 05-10-17

Expected: URL should be of the form: https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b

Merge criteria:

atheo89 commented 2 weeks ago

/lgtm

I could reproduce this ..../experiments/experiment/ae910d56-bdd9-482b-b6a1-5c1f1ae25402

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiridanek Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test images
ci/prow/notebooks-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test notebooks-e2e-tests
ci/prow/habana-notebooks-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test habana-notebooks-e2e-tests
ci/prow/notebooks-ubi8-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test notebooks-ubi8-e2e-tests
ci/prow/codeserver-notebook-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test codeserver-notebook-e2e-tests
ci/prow/rstudio-notebook-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test rstudio-notebook-e2e-tests
ci/prow/intel-notebooks-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test intel-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test notebooks-ubi9-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test runtimes-ubi9-e2e-tests
ci/prow/anaconda-ubi8-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test anaconda-ubi8-e2e-tests
ci/prow/runtimes-ubi8-e2e-tests e3b94ac742610c0021e81dd6c8294c003b1fb94a link true /test runtimes-ubi8-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
harshad16 commented 2 weeks ago

Thank you for the review. i will move forward with merging.