search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

Can we implement filtering to avoid building images for certain file types, such as *.md or *.yaml? Probably as future enhancement #581

Closed jiridanek closed 3 days ago

jiridanek commented 2 weeks ago 
          Can we implement filtering to avoid building images for certain file types, such as *.md or *.yaml? Probably as future enhancement

:thinking: This idea came to me when I opened this PR:: https://github.com/opendatahub-io/notebooks/pull/573

Originally posted by @atheo89 in https://github.com/opendatahub-io/notebooks/issues/558#issuecomment-2175775840

jiridanek commented 2 weeks ago

This should probably check the .dockerignore file and skip building if only ignored files in the directory have changed. Some people put the Dockerfile itself into .dockerignore, so there must be special provision not to skip changes in Dockerfile. Changes in .dockerignore can be ignored as well, I suppose.

jiridanek commented 3 days ago

Closing this as Won't Do, see justification at