opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

ci: get a list of changed files using git diff instead of GitHub APIv4 #602

Closed jiridanek closed 3 days ago

jiridanek commented 1 week ago

This approach is significantly slower than using the GitHub API (3s instead of 1s), but it is less magical for those unfamiliar with the API. So there are reasons to prefer this slower approach.

Description

Fixes #560

How Has This Been Tested?

Merge criteria:

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caponetto, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment