Draft PR to check that #602 changes work correctly in a PR that actually modifies some images

jiridanek commented 3 months ago

Description

https://github.com/opendatahub-io/notebooks/pull/602

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

atheo89 commented 2 months ago

Shall we close this?

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 2 months ago

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/notebooks-ubi8-e2e-tests	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test notebooks-ubi8-e2e-tests`
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror`
ci/prow/amd-runtimes-ubi9-e2e-tests	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test amd-runtimes-ubi9-e2e-tests`
ci/prow/rocm-notebooks-e2e-tests	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test rocm-notebooks-e2e-tests`
ci/prow/notebook-rocm-ubi9-python-3-9-pr-image-mirror	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test notebook-rocm-ubi9-python-3-9-pr-image-mirror`
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror`
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror	175288a3bcf9cbf16ecfb795b9d8ad4863e334e8	link	true	`/test notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

jiridanek commented 2 months ago

Yes

/close

openshift-ci[bot] commented 2 months ago

@jiridanek: Closed this PR.

In response to [this](https://github.com/opendatahub-io/notebooks/pull/603#issuecomment-2239483773): >Yes > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

opendatahub-io / notebooks