ci: filter GitHub Actions PR build by changed files and `.dockerignore`s

jiridanek commented 1 week ago

Description

Fixes #581

How Has This Been Tested?

I'm not conviced this is worth doing. Pretty much the only file that we can .dockerignore are the README.mds under habana/. The issue mentions *.yamls and so on, but these files aren't located in the container image directories, so when they are modified, the images won't rebuild simply because of #558.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 week ago

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

jiridanek commented 1 week ago

Looks like podman will not follow symlink for .dockerignore that leads out of the build context. The images do build in docker just fine, but not in podman.

If I wanted to fix this, I'd add script to ci/ that synces the .dockerignore files and added to static check workflow that all .dockerignores are properly synced.

But, it seems to me that this whole PR is not worth the effort and increased complexity, given how few files there is to be filtered out this way, and that https://github.com/opendatahub-io/notebooks/pull/558 works already pretty well.

jiridanek commented 1 week ago

@atheo89 as the original author of the general idea, do you think this is worth pursuing, or can I close the PR and the issue and not do this, given what I found out in my previous comment?

atheo89 commented 3 days ago

@atheo89 as the original author of the general idea, do you think this is worth pursuing, or can I close the PR and the issue and not do this, given what I found out in my previous comment?

Apologies for the late reply. I appreciate your proposed solution involving syncing .dockerignore files via a script in the CI workflow. Given the minimal number of files that need to be filtered out, I agree that pursuing this change may not justify the added complexity. You can proceed with closing this PR.

opendatahub-io / notebooks