opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
15 stars 51 forks source link

RHOAIENG-1249: Bump `requests` lib to `2.31.0` #608

Open caponetto opened 5 days ago

caponetto commented 5 days ago

https://issues.redhat.com/browse/RHOAIENG-1249

Description

Bump requests lib to 2.31.0 as suggested by Snyk.

Note: Pipfiles are already using this version.

How Has This Been Tested?

Merge criteria:

openshift-ci[bot] commented 5 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

caponetto commented 5 days ago

/retest

atheo89 commented 3 days ago

/lgtm Thanks for the upgrade!

About the failed test, it appears that fall on the second case at this time... (Need to check/fix it in the future to have all test pass)
FWI: https://github.com/opendatahub-io/notebooks/issues/562

caponetto commented 2 days ago

Thanks for the info @atheo89!

BTW this bump should be fine since now there is a match between the versions of requests dependency on Pipfile and requirements-elyra.txt.

atheo89 commented 2 days ago

/override ci/prow/intel-notebooks-e2e-tests

openshift-ci[bot] commented 2 days ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/608#issuecomment-2216853531): >/override ci/prow/intel-notebooks-e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jiridanek, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jiridanek commented 1 day ago

/retest failures don't make much sense to me, lets try again

caponetto commented 1 day ago

/retest

jiridanek commented 21 hours ago

@atheo89 can you please redo this, I guess? /override ci/prow/intel-notebooks-e2e-tests

openshift-ci[bot] commented 21 hours ago

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to [this](https://github.com/opendatahub-io/notebooks/pull/608#issuecomment-2220475329): >@atheo89 can you please redo this, I guess? >/override ci/prow/intel-notebooks-e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
atheo89 commented 9 minutes ago

/override ci/prow/intel-notebooks-e2e-tests

openshift-ci[bot] commented 8 minutes ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/608#issuecomment-2222584369): >/override ci/prow/intel-notebooks-e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.