search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

Update OWNERS file with adding more approvers #611

Closed jstourac closed 1 month ago

jstourac commented 2 months ago

At the moment, there are only the people who are explicitly okay with being approvers for this repository. Please, let me know in case anymore changes are necessary! :slightly_smiling_face:

jiridanek commented 2 months ago

/lgtm

atheo89 commented 1 month ago

It's always good to have new ideas for improvements but I am not fully convinced yet.

I feel that each step of our process should have only the appropriate people, it doent's sound correct to have the same people in two consecutive steps. I mean obviously that could cause a degradation. The owners are the people that know the component almost from end to end, and they have a knowledge history of it.

I will bring an example, Imagine to have a PR open from a contributor that re-introduce some things that are already covered by a feature long time ago, a member from our team likes this changes, imagine now another member that may review this pr and don't know the exact history assign also lgtm, so here, we can have two lgtm so any of these two people can allow a merge. In this scenario a merge could be fatal in our code base.

Also, even if the unit tests would be fully matured (which in our case they aren't) we could not just rely solely on them for approvals etc... So, maybe temporarily we will gain some time but i am afraid that we loose time later on chasing unexpected issues.

jiridanek commented 1 month ago

/test images

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caponetto, harshad16, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstourac commented 1 month ago

Thank you, guys. I'll now backport the changes to other active branches in the upstream. Later in the downstream.

2024a seem to miss just this one commit, so lets do:

/cherrypick 2024a

openshift-cherrypick-robot commented 1 month ago

@jstourac: only opendatahub-io org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/opendatahub-io/notebooks/pull/611#issuecomment-2236783653): >Thank you, guys. I'll now backport the changes to other active branches in the upstream. Later in the downstream. > >2024a seem to miss just this one commit, so lets do: > >/cherrypick 2024a Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstourac commented 1 month ago

/cherrypick 2024a

openshift-cherrypick-robot commented 1 month ago

@jstourac: new pull request created: #623

In response to [this](https://github.com/opendatahub-io/notebooks/pull/611#issuecomment-2236785597): >/cherrypick 2024a Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.