opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

Update of the TrustyAI version in the Jupyter TrustyAI notebook #615

Closed jstourac closed 1 month ago

jstourac commented 1 month ago

The version of the TrustyAI package in the N-1 (2023b) image is actually 0.6.0 for some time already, see [1].

[1] https://issues.redhat.com/browse/RHOAIENG-4027


Merge criteria:

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstourac commented 1 month ago

/override ci/prow/images

I don't believe we need these for such change, though, I expect that bot will tell me I don't have rights to do the above action.

openshift-ci[bot] commented 1 month ago

@jstourac: jstourac unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to [this](https://github.com/opendatahub-io/notebooks/pull/615#issuecomment-2225339990): >/override ci/prow/images > >I don't believe we need these for such change, though, I expect that bot will tell me I don't have rights to do the above action. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
atheo89 commented 1 month ago

prow/images build in every PR if we are in hurry we can override them in this one