Update trusty from 0.3 to 0.6 to fix vulnerabilities

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 55 forks source link

Update trusty from 0.3 to 0.6 to fix vulnerabilities #616

Closed atheo89 closed 1 month ago

atheo89 commented 1 month ago

Description

This PR updates also the 2023a image version is order to get the vulnerability of PyArrow fixed on rhoai 2.8. This should flow to downstream 2023a and then update the manifests of rhoai2.8

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

jiridanek commented 1 month ago

/lgtm

would've been nice to see trivy again on this, but it's just backport, so I'm willing to believe

atheo89 commented 1 month ago

Yes, It would be nice to open a separated dummy PR and check everything. Since this is backport i will move to it

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/2023a/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

atheo89 commented 1 month ago

Thanks @jstourac, about the first point, it doesn't really need, since from the YYYYx branches we only build the notebooks, the difference comes in place on the manifest files on the rhoai x.y branches. About the second, yes since now we have already go to 0.6 let's keep an homogeneity and keep this consideration for future upgrades.

atheo89 commented 1 month ago

/override ci/prow/images
These images are failing because we don't have backport this https://github.com/opendatahub-io/notebooks/pull/570

openshift-ci[bot] commented 1 month ago

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images

In response to [this](https://github.com/opendatahub-io/notebooks/pull/616#issuecomment-2225170984): >/override ci/prow/images >These images are failing because we don't have backport this https://github.com/opendatahub-io/notebooks/pull/570 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

jstourac commented 1 month ago

/override ci/prow/images These images are failing because we don't have backport this #570

I created this to track it https://issues.redhat.com/browse/RHOAIENG-9801.

jstourac commented 1 month ago

Since this is merged now, we need to not forget to update manifests together with the images updates in the rhoai-2.8 branch.