opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

[2023a] RHOAIENG-9801: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #617

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #553

/assign jiridanek

openshift-ci[bot] commented 1 month ago

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jiridanek commented 1 month ago

/retitle [2023a] RHOAIENG-9801: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location /label tide/merge-method-squash

atheo89 commented 1 month ago

Cool! Thanks for opening this against 2023a branch /lgtm /approve

Just a kind reminder, once this PR get merged, remember to merge the one that will open automatically on downstream.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/2023a/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atheo89 commented 1 month ago

/ok-to-test

jiridanek commented 1 month ago

and this additional change in downstream-only

atheo89 commented 1 month ago

Nope, now we have pull bot, It will open a PR once this get merged.

atheo89 commented 1 month ago

/test images

atheo89 commented 1 month ago

Hey @jiridanek I open this cherry pick pr to fix the rest issues for habana https://github.com/opendatahub-io/notebooks/pull/619 Could you take a look?

atheo89 commented 1 month ago

/test images

harshad16 commented 1 month ago

Thanks for the fix :100: