RHOAIENG-9741: Add Tensorflow/PyTorch version compatibility files

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 55 forks source link

RHOAIENG-9741: Add Tensorflow/PyTorch version compatibility files #618

Closed caponetto closed 1 month ago

caponetto commented 1 month ago

https://issues.redhat.com/browse/RHOAIENG-9741

Description

Adding version compatibility files for TensorFlow and PyTorch. Values for TensorFlow were extracted from here via script. Values for PyTorch were manually extracted from here and here. The idea is to refer to these files during the release automation, and also keep them up to date whenever a new release is out.

Note: TensorFlow 2.17.0 was released yesterday. I'll add this new release to the file as soon as the information is consolidated.

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

jiridanek commented 1 month ago

Values for TensorFlow were extracted from here via script.

Maybe add the script into the repository under scripts/ and the commentary on the PR into the README.md?

caponetto commented 1 month ago

Values for TensorFlow were extracted from here via script.

Maybe add the script into the repository under scripts/ and the commentary on the PR into the README.md?

TBH I don't see much value in adding a simple script that parses a markdown table. New manual entries will be added to the files for the upcoming versions anyway.

atheo89 commented 1 month ago

/lgtm

I would like to have a comment somehow inside .json files in order to point the places that we scrape this info. However, I know that json doesn't support comments! So maybe we could mention it on readme or in the Wiki

caponetto commented 1 month ago

/lgtm

I would like to have a comment somehow inside .json files in order to point the places that we scrape this info. However, I know that json doesn't support comments! So maybe we could mention it on readme or in the Wiki

@atheo89 I agree! We will have a dedicated wiki page for the release once the automation is in place, so I would add this information on this page later. WDYT?

jiridanek commented 1 month ago

/lgtm, and I'm in favor of readme; wikis go stale even faster than readmes

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

jiridanek commented 1 month ago

/lgtm /lgtm /lgtm

atheo89 commented 1 month ago

dedicated wiki page for the release

Sounds great!

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment