Closed harshad16 closed 1 month ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Looks like we need to update the prow configuration then too:
Also Makefile should be updated (in this PR), to reference ubi9- and not c9s- dir.
We're still running out of disk space on one of the images, as @caponetto observed yesterday.
ci/prow/notebook-amd-c9s-python-3-9-pr-image-mirror — Job failed. BaseSHA:fecd10c13ce13d66b57498abc48976f74121dd63
so openshift-ci needs to be updated
@jstourac so, approving in GitHub UI gives BOTH LGTM and approved, now that we are approvers. Gotta be careful.
We're still running out of disk space on one of the images, as @caponetto observed yesterday.
At first, I thought that was happening only during Trivy scan because it has to copy stuff around. But then I saw that CI is running out of disk space even during the build step for amd-jupyter-pytorch-ubi9-python-3.9
(examples are this PR and some builds triggered after a merge). Considering that amd-jupyter-pytorch-ubi9-python-3.9
is ~60 GB uncompressed, the CI is operating on its limit. If we ever need to add new things to this image, we'll probably face these storage issues more often.
Apparently, there are more people concerned about rocm+pytorch size (see https://github.com/ROCm/ROCm-docker/issues/120)
To fix the ci please check this PR: https://github.com/opendatahub-io/notebooks/pull/627 explains the instructions on how you can update the notebook matrix
@harshad16: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/notebooks-ubi8-e2e-tests | b8a1d3fc41869aea6e9a20e3e8e990d7d82ec06f | link | true | /test notebooks-ubi8-e2e-tests |
ci/prow/notebook-amd-c9s-python-3-9-pr-image-mirror | 3cfe039432c8d28ea3077569a98ea6333d62014c | link | true | /test notebook-amd-c9s-python-3-9-pr-image-mirror |
ci/prow/notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror | 3cfe039432c8d28ea3077569a98ea6333d62014c | link | true | /test notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror |
ci/prow/amd-runtimes-ubi9-e2e-tests | 3cfe039432c8d28ea3077569a98ea6333d62014c | link | true | /test amd-runtimes-ubi9-e2e-tests |
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror | 3cfe039432c8d28ea3077569a98ea6333d62014c | link | true | /test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror |
Full PR test history. Your PR dashboard.
/lgtm /approve
/override ci/prow/images /override /ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror /override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror /override ci/prow/rocm-notebooks-e2e-tests
@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:
/ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror
Only the following failed contexts/checkruns were expected:
build (rocm-jupyter-pytorch-ubi9-python-3.9) / build
ci/prow/images
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-rocm-ubi9-python-3-9-pr-image-mirror
ci/prow/rocm-notebooks-e2e-tests
pull-ci-opendatahub-io-notebooks-2023a-images
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests
tide
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: atheo89, jiridanek, jstourac
The full list of commands accepted by this bot can be found here.
The pull request process is described here
let me try
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build" /override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror /override ci/prow/rocm-notebooks-e2e-tests /override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror /override ci/prow/images
@jiridanek: Overrode contexts on behalf of jiridanek: build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/rocm-notebooks-e2e-tests
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:
build (rocm-jupyter-pytorch-ubi9-python-3.9) / build
Only the following failed contexts/checkruns were expected:
ci/prow/images
ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror
ci/prow/notebook-rocm-ubi9-python-3-9-pr-image-mirror
ci/prow/rocm-notebooks-e2e-tests
pull-ci-opendatahub-io-notebooks-2023a-images
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-ubi9-python-3-9-pr-image-mirror
pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests
tide
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.
Description
Switch base image to UBI for AMD rocm install Related-to: https://issues.redhat.com/browse/RHOAIENG-7501
How Has This Been Tested?
Merge criteria: