search

opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

[2024a] Update OWNERS file with adding more approvers #623

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #611

/assign jstourac

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/2024a/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
harshad16 commented 1 month ago

Lets directly sync 2024a and main . lets not cherry-pick. /hold

jstourac commented 1 month ago

Sure @harshad16. I suppose I shall close this one then?

harshad16 commented 1 month ago

yes please

jiridanek commented 1 month ago

/close

openshift-ci[bot] commented 1 month ago

@jiridanek: Closed this PR.

In response to [this](https://github.com/opendatahub-io/notebooks/pull/623#issuecomment-2242856146): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.