feat(ci): add helpful error when check-generated-code gha workflow fails

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 55 forks source link

feat(ci): add helpful error when check-generated-code gha workflow fails #627

Closed jiridanek closed 1 month ago

jiridanek commented 1 month ago

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

atheo89 commented 1 month ago

/lgtm

jstourac commented 1 month ago

Thank you, I like this much more now!

/lgtm

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

jiridanek commented 1 month ago

/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror /override ci/prow/amd-runtimes-ubi9-e2e-tests /override ci/prow/images

one rocm run out of ephemeral storage, and tests hit the chicken-and-egg problem from https://github.com/openshift/release/pull/54567

openshift-ci[bot] commented 1 month ago

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/amd-runtimes-ubi9-e2e-tests, ci/prow/images, ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror

In response to [this](https://github.com/opendatahub-io/notebooks/pull/627#issuecomment-2238984308): >/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror >/override ci/prow/amd-runtimes-ubi9-e2e-tests >/override ci/prow/images > >one rocm run out of ephemeral storage, and tests hit the chicken-and-egg problem from https://github.com/openshift/release/pull/54567 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.