opendatahub-io / notebooks

Notebook images for ODH
Apache License 2.0
17 stars 55 forks source link

Combine `RUN` commands to reduce rocm image size #634

Closed caponetto closed 1 month ago

caponetto commented 1 month ago

Description

Image size comparison before -> after these changes:

Note: Both files are now exactly the same, except for the labels.

How Has This Been Tested?

Run the build workflow with the changes included

Merge criteria:

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [jiridanek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atheo89 commented 1 month ago

/lgtm

jiridanek commented 1 month ago

/override ci/prow/rocm-runtimes-ubi9-e2e-tests /override ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror /override ci/prow/images /override ci/prow/rocm-notebooks-e2e-tests

these things don't build because image is too big, and this PR will shrink the image

openshift-ci[bot] commented 1 month ago

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror

In response to [this](https://github.com/opendatahub-io/notebooks/pull/634#issuecomment-2248255040): >/override ci/prow/rocm-runtimes-ubi9-e2e-tests >/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror >/override ci/prow/images >/override ci/prow/rocm-notebooks-e2e-tests > >these things don't build because image is too big, and this PR will shrink the image Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jiridanek commented 1 month ago

/override ci/prow/runtimes-ubi8-e2e-tests /override ci/prow/runtimes-ubi9-e2e-tests /override ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror /override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror /override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror

openshift-ci[bot] commented 1 month ago

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror, ci/prow/runtimes-ubi8-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/634#issuecomment-2248258140): >/override ci/prow/runtimes-ubi8-e2e-tests >/override ci/prow/runtimes-ubi9-e2e-tests >/override ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror >/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror >/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.