Closed caponetto closed 1 month ago
I don't like how complicated is the ci script becoming. So many variables. Let's see first if the grouping of run commands can make trivy image scan run?
Maybe there's still something else to shrink the images they can be tried?
TBH I don't like to see a red CI every day. So I'd rather have this code in while we progress with the image optimizations.
/lgtm i'm not happy, but if we want to have passing trivy, this is the way
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/override ci/prow/rocm-notebooks-e2e-tests /override ci/prow/images
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/images, ci/prow/rocm-notebooks-e2e-tests
Description
Run Trivy scan
fs
instead ofimage
for rocm+pytorch image due to resource constraints. At least, the daily report and PR will pass and will show the results for the lock file while we don't reduce the image size.How Has This Been Tested?
Run the updated workflow for the pytorch image and another one to check both behaviors (image and fs)
Merge criteria: