RHOAIENG-10350 feat(Dockerfiles): switch from s2i python images to plain ubi/c9s bases

jiridanek commented 1 month ago

https://issues.redhat.com/browse/RHOAIENG-10350

Description

The main benefit is size and cve exposure, as the python images come with packages we don't use; python and pip is enough for us.

Every image is made approx 300MB smaller by doing this!

Before:

rstudio-c9s-python-3.9-main_dbeac5b  4c5c83479bb2  7 seconds ago      3.44 GB

After:

rstudio-c9s-python-3.9-jd_ubi_base_adedd4a  040b74e5a618  50 minutes ago     3.08 GB

Additionally, using plain ubi makes things more explicit.

How Has This Been Tested?

I'll test this when making this change is planned into a sprint.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jiridanek commented 1 month ago

This PR is great, definitely will be good to have however

Great! In that case I'll go forward creating a Jira so this can be groomed. https://issues.redhat.com/browse/RHOAIENG-10350

jiridanek commented 1 month ago

the s2i image bring working dir: /opt/app-root/src

our images explicitly set this in the WORKDIR instruction, so we're good in that respect

however we should thoroughly check these changes.

sure, that's why I created a jira for doing all the work in organized manner; the disk space savings are not all that significant, but I like how this removes much of the s2i magic, so that's what makes this seem worth doing to me

jstourac commented 1 month ago

BTW, I was wondering what are the most important changes, so I prepared some basic script for the image comparison (I have a plan to improve it further and put it into our CI/GHA for our convenience). I tried to compare one of the base images you change here with what we have (note that your build is 2 weeks old, I took the quay image from today):

checkout this branch https://github.com/opendatahub-io/notebooks/compare/main...jstourac:notebooks:compareImages

run this:

./ci/compare-images.sh quay.io/opendatahub/workbench-images@sha256:e92bf20e127e545bdf56887903dc72ad227082b8bc23f45ff4f0fc67e6430318 ghcr.io/jiridanek/notebooks/workbench-images:base-ubi9-python-3.9-jd_ubi_base_adedd4a943977ecdcb67bc6eb9eda572d10c3ddc

openshift-ci[bot] commented 1 week ago

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/habana-notebooks-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test habana-notebooks-e2e-tests`
ci/prow/images	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test images`
ci/prow/notebooks-ubi8-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test notebooks-ubi8-e2e-tests`
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror`
ci/prow/notebook-rocm-ubi9-python-3-11-pr-image-mirror	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test notebook-rocm-ubi9-python-3-11-pr-image-mirror`
ci/prow/notebook-rocm-jupyter-min-ubi9-python-3-11-pr-image-mirror	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test notebook-rocm-jupyter-min-ubi9-python-3-11-pr-image-mirror`
ci/prow/runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror`
ci/prow/codeserver-notebook-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test codeserver-notebook-e2e-tests`
ci/prow/notebooks-ubi9-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test notebooks-ubi9-e2e-tests`
ci/prow/rstudio-notebook-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test rstudio-notebook-e2e-tests`
ci/prow/intel-notebooks-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test intel-notebooks-e2e-tests`
ci/prow/runtimes-ubi9-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test runtimes-ubi9-e2e-tests`
ci/prow/rocm-runtimes-ubi9-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test rocm-runtimes-ubi9-e2e-tests`
ci/prow/rocm-notebooks-e2e-tests	adedd4a943977ecdcb67bc6eb9eda572d10c3ddc	link	true	`/test rocm-notebooks-e2e-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

opendatahub-io / notebooks