Upgrade Notebook with codeflare-sdk version 0.21.1

harshad16 commented 1 month ago

Description

Upgrade Notebook with codeflare-sdk version 0.21.1 Fixes: #719

As the github action failed: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11134262380

How Has This Been Tested?

NA

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jiridanek commented 1 month ago

/lgtm

jiridanek commented 1 month ago

/retest-required

jstourac commented 1 month ago

@harshad16, are these skipped intentionally? Not touching any intel ones?

jupyter/intel/ml/ubi9-python-3.11/Pipfile:codeflare-sdk = "~=0.19.1"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
jupyter/intel/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/ml/ubi9-python-3.11/Pipfile:codeflare-sdk = "~=0.19.1"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/pytorch/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.cpu:codeflare-sdk = "~=0.13.0"
intel/runtimes/tensorflow/ubi9-python-3.11/Pipfile.gpu:codeflare-sdk = "~=0.13.0"

harshad16 commented 1 month ago

are these skipped intentionally? Not touching any intel ones?

yes @jstourac currently it isn't part of our OOTB I m leaving it out of the custom PR, lets see it later on.

jstourac commented 1 month ago

are these skipped intentionally? Not touching any intel ones?

yes @jstourac currently it isn't part of our OOTB I m leaving it out of the custom PR, lets see it later on.

Great, thanks for confirmation, Harshad.

In that case /lgtm for this one.

As such, should we ignore python 3.9 and intel based images in the GHA from the codeflare sdk repository?

harshad16 commented 1 month ago

As such, should we ignore python 3.9 and intel based images in the GHA from the codeflare sdk repository?

i m sure on python3.9
about intel, will confirm after some discussions.

harshad16 commented 1 month ago

Thanks for all the review

/approve

/override ci/prow/images /override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror /override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests /override ci/prow/rocm-runtimes-ubi9-e2e-tests /override ci/prow/runtimes-ubi9-e2e-tests

openshift-ci[bot] commented 1 month ago

@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/725#issuecomment-2391441401): >Thanks for all the review > >/approve > > >/override ci/prow/images >/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror >/override ci/prow/notebooks-ubi9-e2e-tests >/override ci/prow/rocm-notebooks-e2e-tests >/override ci/prow/rocm-runtimes-ubi9-e2e-tests >/override ci/prow/runtimes-ubi9-e2e-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Srihari1192 commented 1 month ago

@harshad16 Also can you include this codeflare-sdk version 0.21.1 changes to the notebook for RHOAI 2.14 release branch

harshad16 commented 1 month ago

@Srihari1192 all the work would be moved today to release branch.

opendatahub-io / notebooks