[Fix] manifest for TensorFlow image to show proper Numpy package version

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 64 forks source link

[Fix] manifest for TensorFlow image to show proper Numpy package version #743

Closed jstourac closed 1 month ago

jstourac commented 1 month ago

This partially reverts the opendatahub-io/notebooks#742 to fix the expected version in the final image.

Description

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

jiridanek commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jstourac commented 1 month ago

/approved /override ci/prow/images

openshift-ci[bot] commented 1 month ago

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to [this](https://github.com/opendatahub-io/notebooks/pull/743#issuecomment-2411127993): >/approved >/override ci/prow/images Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

jstourac commented 1 month ago

/override pytest-tests

openshift-ci[bot] commented 1 month ago

@jstourac: Overrode contexts on behalf of jstourac: pytest-tests

In response to [this](https://github.com/opendatahub-io/notebooks/pull/743#issuecomment-2411155680): >/override pytest-tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.