NO-JIRA: chore(gha): fix poetry install in GitHub Actions

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 64 forks source link

NO-JIRA: chore(gha): fix poetry install in GitHub Actions #744

Closed jiridanek closed 1 month ago

jiridanek commented 1 month ago

Description

Currently, pip install refuses to install outside of a virtual env without --break-system-packages.

To fix this, let's install with pipx and let's configure pipx for GHA caching.

How Has This Been Tested?

GHA

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jiridanek commented 1 month ago

/cc @jstourac

jstourac commented 1 month ago

/lgtm

jiridanek commented 1 month ago

/override ci/prow/images /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [jiridanek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to [this](https://github.com/opendatahub-io/notebooks/pull/744#issuecomment-2411520996): >/override ci/prow/images >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.