RHOAIENG-2003: feat(metadata/codeserver): update VSCode imagestream annotations with installed software

jiridanek commented 3 weeks ago

https://issues.redhat.com/browse/RHOAIENG-2003

Description

Took into account the good suggestions from https://issues.redhat.com/browse/RHOAIRFE-320 as well.

The n annotations are for https://github.com/opendatahub-io/notebooks/blob/main/codeserver/ubi9-python-3.11/Pipfile
The n-1 annotations describe https://github.com/opendatahub-io/notebooks/blob/2024a/codeserver/ubi9-python-3.9/Pipfile

I've also added the # language=json injection comment described at https://www.jetbrains.com/help/idea/using-language-injections.html#use-language-injection-comments. If there's something similar for people using different IDEs, we can change it for something more portable later.

Finally, I put some newlines into the annotation, to make it easier for people to read it.

Screenshot 2024-10-29 at 1 53 18 PM

How Has This Been Tested?

I'm going to run Kustomize, copy out the rendered manifest, rename it, and put it into my cluster. Then I'll check in the dashboard how it renders.

oc login --web
cd manifests/base
../../kustomize-5.0.2 edit set namespace redhat-ods-application
../../kustomize-5.0.2 edit set nameprefix main-
../../kustomize-5.0.2 build . | oc apply -f -

Screenshot 2024-10-29 at 4 53 35 PM

Screenshot 2024-10-29 at 4 52 58 PM

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

jstourac commented 3 weeks ago

@jiridanek thank you for this and thank you for enhancing/fixing the CI for this change.

In general this LGTM and I put just one comment regarding the addition of the UBI information here. I don't insist on the removal but I think we should consider it.

atheo89 commented 2 weeks ago

Great representation by using the # language=json, imo, we should do the same to the rest of the ImageStreams to keep consistency. /lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [atheo89] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jiridanek commented 2 weeks ago

/override ci/prow/images

rocm failed to build

openshift-ci[bot] commented 2 weeks ago

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to [this](https://github.com/opendatahub-io/notebooks/pull/756#issuecomment-2450482090): >/override ci/prow/images > >rocm failed to build Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

jiridanek commented 2 weeks ago

we should do the same to the rest of the ImageStreams to keep consistency.

absolutely, filled task https://issues.redhat.com/browse/RHOAIENG-15242

opendatahub-io / notebooks