Remove of the CUDA RPM repository definition for arm arch

opendatahub-io / notebooks

Notebook images for ODH

Apache License 2.0

17 stars 64 forks source link

Remove of the CUDA RPM repository definition for arm arch #759

Closed jstourac closed 2 weeks ago

jstourac commented 2 weeks ago

This file isn't used anywhere in our codebase right now, so it's unnecessary to have it here.

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

jiridanek commented 2 weeks ago

/lgtm it's a shame we dont build for arm64, it would be good for me to run on my mac, we should start building arm64 eventually

atheo89 commented 2 weeks ago

/lgtm

jstourac commented 2 weeks ago

Thank you for your reviews, guys!

The prow job failures are irrelevant to the change in this PR so I'm gonna merge this one now.

/override ci/prow/images /approve

openshift-ci[bot] commented 2 weeks ago

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to [this](https://github.com/opendatahub-io/notebooks/pull/759#issuecomment-2456425973): >Thank you for your reviews, guys! > >The prow job failures are irrelevant to the change in this PR so I'm gonna merge this one now. > >/override ci/prow/images >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/notebooks/blob/main/OWNERS)~~ [jstourac] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment