ImagePullBackOff is not handled as error during workbench start

[dpanshug]

Closes: RHOAIENG-1132

Description

Added case to handle notebook failure when reason === "BackOff"

How Has This Been Tested?

1. Create a custom image from Settings > Notebook images (e.g., quay.io/myfakeimages/myimage:1234)
2. create a workbench and select the custom image as notebook image
3. compare the pod and workbench status

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

• [x] The developer has manually tested the changes and verified that the changes work
• [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• [x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• [x] Included any necessary screenshots or gifs if it was a UI change.
• [x] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• [ ] The developer has tested their solution on a cluster by using the image produced by the PR to main @xianli123

[dpanshug]

@simrandhaliw tagging you as well, since you were involved in this UX discussion.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (947c09b) to head (0390bef). Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/src/pages/projects/notebook/utils.ts	0.00%	3 Missing :warning:
frontend/src/utilities/notebookControllerUtils.ts	0.00%	3 Missing :warning:

Additional details and impacted files

[](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3260 +/- ## ========================================== - Coverage 84.87% 84.86% -0.01% ========================================== Files 1306 1306 Lines 29173 29179 +6 Branches 7859 7861 +2 ========================================== + Hits 24761 24764 +3 - Misses 4412 4415 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [frontend/src/pages/projects/notebook/utils.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2Fprojects%2Fnotebook%2Futils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL3Byb2plY3RzL25vdGVib29rL3V0aWxzLnRz) | `32.31% <0.00%> (-0.61%)` | :arrow_down: | | [frontend/src/utilities/notebookControllerUtils.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?src=pr&el=tree&filepath=frontend%2Fsrc%2Futilities%2FnotebookControllerUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3V0aWxpdGllcy9ub3RlYm9va0NvbnRyb2xsZXJVdGlscy50cw==) | `38.75% <0.00%> (-0.50%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [947c09b...0390bef](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3260?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).

[dpanshug]

@andrewballantyne @simrandhaliw with the recent design change in the workbenches https://github.com/opendatahub-io/odh-dashboard/pull/3207 , the tooltip is removed and instead of "Starting" it is displaying "Failed" as the status is Error.

Before

With latest design

Can you please confirm if the "Failed" status works in this case of ImagePullBackOff?

[andrewballantyne]

ImagePullBackOff errors are sometimes transient... Failed is probably not the best word... but I don't think it's technically the wrong word.

@dpanshug is this UI the same on the Workbench Table as well as the Project screen?

[dpanshug]

@dpanshug is this UI the same on the Workbench Table as well as the Project screen?

@andrewballantyne yes it's same

[dpanshug]

/retest

[DaoDaoNoCode]

@dpanshug I am not sure why the file scan keeps failing. Maybe try to rebase the main branch and push it again?

[manaswinidas]

/lgtm

[Gkrumbach07]

the tooltip error says it is a [Warning], should there be another state for this notebook status chip?

[xianli123]

thx @dpanshug /lgtm

[dpanshug]

the tooltip error says it is a [Warning], should there be another state for this notebook status chip?

@Gkrumbach07 ImagePullBackOff are errors that occur when container running in a pod fails to pull the required image from a container registry. The message might mention it as warning, but as mentioned previously in the JIRA we should display it as an error.

[Gkrumbach07]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)~~ [Gkrumbach07] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment