search

opendatahub-io / odh-dashboard

Dashboard for ODH
Apache License 2.0
28 stars 160 forks source link

NIM deployment #3265

Closed olavtar closed 1 week ago

olavtar commented 1 week ago

https://issues.redhat.com/browse/APPENG-2712

Description

Added secret deletion and deploy button links fixed in empty state to point to NIM modal.

How Has This Been Tested?

Tested locally.

Test Impact

Verified resource creation and deletion during model deployment and removal.

Request review criteria:

Self checklist (all need to be checked):

If you have UI changes:

After the PR is posted & before it merges:

openshift-ci[bot] commented 1 week ago

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andrewballantyne commented 1 week ago

/ok-to-test

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (a0d40fd) to head (6428443). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ing/screens/global/DeleteInferenceServiceModal.tsx 64.28% 5 Missing :warning:
...lServing/screens/projects/ModelServingPlatform.tsx 25.00% 3 Missing :warning:
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 1 Missing :warning:
...rc/pages/modelServing/screens/projects/nimUtils.ts 50.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265/graphs/tree.svg?width=650&height=150&src=pr&token=UQM7NLQUXJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io)](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3265 +/- ## ========================================== - Coverage 84.96% 84.96% -0.01% ========================================== Files 1302 1302 Lines 29101 29120 +19 Branches 7828 7843 +15 ========================================== + Hits 24727 24742 +15 - Misses 4374 4378 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [frontend/src/k8sTypes.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fk8sTypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL2s4c1R5cGVzLnRz) | `100.00% <ø> (ø)` | | | [...s/projects/NIMServiceModal/NIMModelListSection.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FNIMServiceModal%2FNIMModelListSection.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL05JTVNlcnZpY2VNb2RhbC9OSU1Nb2RlbExpc3RTZWN0aW9uLnRzeA==) | `1.63% <ø> (ø)` | | | [...verModels/deployedModels/DeployedModelsSection.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2Fprojects%2Fscreens%2Fdetail%2Foverview%2FserverModels%2FdeployedModels%2FDeployedModelsSection.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL3Byb2plY3RzL3NjcmVlbnMvZGV0YWlsL292ZXJ2aWV3L3NlcnZlck1vZGVscy9kZXBsb3llZE1vZGVscy9EZXBsb3llZE1vZGVsc1NlY3Rpb24udHN4) | `100.00% <100.00%> (ø)` | | | [...projects/NIMServiceModal/DeployNIMServiceModal.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FNIMServiceModal%2FDeployNIMServiceModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL05JTVNlcnZpY2VNb2RhbC9EZXBsb3lOSU1TZXJ2aWNlTW9kYWwudHN4) | `5.94% <0.00%> (ø)` | | | [...rc/pages/modelServing/screens/projects/nimUtils.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FnimUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL25pbVV0aWxzLnRz) | `52.27% <50.00%> (ø)` | | | [...lServing/screens/projects/ModelServingPlatform.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FModelServingPlatform.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL01vZGVsU2VydmluZ1BsYXRmb3JtLnRzeA==) | `91.48% <25.00%> (-2.96%)` | :arrow_down: | | [...ing/screens/global/DeleteInferenceServiceModal.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fglobal%2FDeleteInferenceServiceModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL2dsb2JhbC9EZWxldGVJbmZlcmVuY2VTZXJ2aWNlTW9kYWwudHN4) | `76.47% <64.28%> (-4.62%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [a0d40fd...6428443](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3265?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)~~ [andrewballantyne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andrewballantyne commented 1 week ago

/override ci/prow/images /override ci/prow/odh-dashboard-pr-image-mirror

Needing this to merge -- not sure why it's having issues on completing the image. Another no-need for the image. Once the PR is merged we should have one built off main.

openshift-ci[bot] commented 1 week ago

@andrewballantyne: Overrode contexts on behalf of andrewballantyne: ci/prow/images, ci/prow/odh-dashboard-pr-image-mirror

In response to [this](https://github.com/opendatahub-io/odh-dashboard/pull/3265#issuecomment-2379477787): >/override ci/prow/images >/override ci/prow/odh-dashboard-pr-image-mirror > >Needing this to merge -- not sure why it's having issues on completing the image. Another no-need for the image. Once the PR is merged we should have one built off main. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.