opendatahub-io / odh-dashboard

Dashboard for ODH
Apache License 2.0
28 stars 160 forks source link

Nim double window #3268

Closed olavtar closed 1 week ago

olavtar commented 1 week ago

Description

Resolved double window and NIM modal showing for KServe. Added a link to EmptyModelServing for NIM project.

How Has This Been Tested?

Tested locally.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

If you have UI changes:

After the PR is posted & before it merges:

openshift-ci[bot] commented 1 week ago

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
andrewballantyne commented 1 week ago

/ok-to-test

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)~~ [andrewballantyne] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (6565ca9) to head (28e0fd9). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lServing/screens/projects/ModelServingPlatform.tsx 60.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268/graphs/tree.svg?width=650&height=150&src=pr&token=UQM7NLQUXJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io)](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3268 +/- ## ========================================== - Coverage 84.86% 84.85% -0.02% ========================================== Files 1306 1306 Lines 29197 29191 -6 Branches 7881 7884 +3 ========================================== - Hits 24779 24770 -9 - Misses 4418 4421 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [.../modelServing/screens/global/EmptyModelServing.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fglobal%2FEmptyModelServing.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL2dsb2JhbC9FbXB0eU1vZGVsU2VydmluZy50c3g=) | `83.33% <100.00%> (+2.08%)` | :arrow_up: | | [...lServing/screens/projects/ModelServingPlatform.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FModelServingPlatform.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL01vZGVsU2VydmluZ1BsYXRmb3JtLnRzeA==) | `91.48% <60.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [50a1054...28e0fd9](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3268?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).