Closed olavtar closed 1 week ago
Hi @olavtar. Thanks for your PR.
I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andrewballantyne
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.85%. Comparing base (
6565ca9
) to head (28e0fd9
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...lServing/screens/projects/ModelServingPlatform.tsx | 60.00% | 2 Missing :warning: |
Description
Resolved double window and NIM modal showing for KServe. Added a link to EmptyModelServing for NIM project.
How Has This Been Tested?
Tested locally.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main