Search - 'Clear all Filters' doesn't work

YuliaKrimerman commented 4 days ago

https://issues.redhat.com/browse/RHOAIENG-12861

Description

Clear all filters button is now working on all existing screens
Changed label that was mentioned in RHOAI sprint demos.

How Has This Been Tested?

on the UI

Test Impact

Updated tests to pass after the label change. In order to test the change, verify that now "Clear all Filters' button is now working everywhere it exists

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.84%. Comparing base (330dfdf) to head (454e81f). Report is 9 commits behind head on main.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271/graphs/tree.svg?width=650&height=150&src=pr&token=UQM7NLQUXJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io)](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3271 +/- ## ========================================== - Coverage 84.88% 84.84% -0.05% ========================================== Files 1306 1307 +1 Lines 29196 29186 -10 Branches 7885 7872 -13 ========================================== - Hits 24784 24763 -21 - Misses 4412 4423 +11 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [frontend/src/concepts/k8s/NameDescriptionField.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fconcepts%2Fk8s%2FNameDescriptionField.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL2NvbmNlcHRzL2s4cy9OYW1lRGVzY3JpcHRpb25GaWVsZC50c3g=) | `92.10% <ø> (ø)` | | | [...istry/screens/ModelVersions/ModelVersionsTable.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FModelVersions%2FModelVersionsTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9Nb2RlbFZlcnNpb25zL01vZGVsVmVyc2lvbnNUYWJsZS50c3g=) | `100.00% <ø> (ø)` | | | [...ModelVersionsArchive/ModelVersionsArchiveTable.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FModelVersionsArchive%2FModelVersionsArchiveTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9Nb2RlbFZlcnNpb25zQXJjaGl2ZS9Nb2RlbFZlcnNpb25zQXJjaGl2ZVRhYmxlLnRzeA==) | `100.00% <ø> (ø)` | | | [...reens/RegisteredModels/RegisteredModelListView.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FRegisteredModels%2FRegisteredModelListView.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9SZWdpc3RlcmVkTW9kZWxzL1JlZ2lzdGVyZWRNb2RlbExpc3RWaWV3LnRzeA==) | `77.41% <ø> (-2.00%)` | :arrow_down: | | [.../screens/RegisteredModels/RegisteredModelTable.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FRegisteredModels%2FRegisteredModelTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9SZWdpc3RlcmVkTW9kZWxzL1JlZ2lzdGVyZWRNb2RlbFRhYmxlLnRzeA==) | `100.00% <ø> (ø)` | | | [.../RegisteredModels/RegisteredModelsTableToolbar.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FRegisteredModels%2FRegisteredModelsTableToolbar.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9SZWdpc3RlcmVkTW9kZWxzL1JlZ2lzdGVyZWRNb2RlbHNUYWJsZVRvb2xiYXIudHN4) | `88.46% <100.00%> (+0.46%)` | :arrow_up: | | [...eredModelsArchive/RegisteredModelsArchiveTable.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FRegisteredModelsArchive%2FRegisteredModelsArchiveTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9SZWdpc3RlcmVkTW9kZWxzQXJjaGl2ZS9SZWdpc3RlcmVkTW9kZWxzQXJjaGl2ZVRhYmxlLnRzeA==) | `100.00% <ø> (ø)` | | | [frontend/src/pages/projects/pvc/MountPathField.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2Fprojects%2Fpvc%2FMountPathField.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL3Byb2plY3RzL3B2Yy9Nb3VudFBhdGhGaWVsZC50c3g=) | `100.00% <100.00%> (ø)` | | ... and [41 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [330dfdf...454e81f](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3271?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).

ppadti commented 3 days ago

@YuliaKrimerman I think we need to fix this issue in Deployed models page as well.

YuliaKrimerman commented 3 days ago

@ppadti I was trying to add that fix into InferenceServiceTable inside the Table, but even though it has emptyTableView that whole chip group is not showing, what am I missing?

ppadti commented 1 day ago

@ppadti I don't think we have a toolbar with filters for the deployments tab here as per the mocks. Let me know if you're referring to some other mock links.

Yeah, I was referring to this slack conversation here.

YuliaKrimerman commented 1 day ago

@ppadti , @manaswinidas As I mentioned above I was trying to add that fix into InferenceServiceTable(it's the right file correct?) inside the Table, but even though it has emptyTableView that whole chip group is not showing, what am I missing? Any suggestions? And yes, I suggested to fix it as part of that PR in that conversation, but just got stuck, and preferred to, at least put the required solution for the actual bug

ppadti commented 1 day ago

@ppadti , @manaswinidas As I mentioned above I was trying to add that fix into InferenceServiceTable(it's the right file correct?) inside the Table, but even though it has emptyTableView that whole chip group is not showing, what am I missing? Any suggestions? And yes, I suggested to fix it as part of that PR in that conversation, but just got stuck, and preferred to, at least put the required solution for the actual bug

May be because it is using DashboardSearchField and not ToolbarFilter and we have this issue in some other places as well for ex: Accelerator profile and Notebook images page. I think we need to discuss this with the team and can have a separate issue to address this, if needed. wdyt?

YuliaKrimerman commented 1 day ago

Sounds good to me, I can open an issue for it, and will address the related PR comments then.

YuliaKrimerman commented 1 day ago

@manaswinidas Addressed comment, ready for re-review. Also created a story for us to discuss https://issues.redhat.com/browse/RHOAIENG-13924 . @ppadti . Thank you!

opendatahub-io / odh-dashboard