opendatahub-io / odh-dashboard

Dashboard for ODH
Apache License 2.0
28 stars 160 forks source link

Update empty state of versions list and models lists #3277

Open ppadti opened 4 days ago

ppadti commented 4 days ago

Closes: RHOAIENG-12863

Description

This PR aims to update the empty state of versions list and models list to show the secondary action only when there are archived versions / archived models.

How Has This Been Tested?

Check for empty state of versions list with no archived versions. Check for empty state of models list with no archived models.

Test Impact

NA, just rendering the empty state actions conditionally.

Request review criteria:

Self checklist (all need to be checked):

If you have UI changes:

After the PR is posted & before it merges:

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.87%. Comparing base (d5938bf) to head (f311c83). Report is 35 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277/graphs/tree.svg?width=650&height=150&src=pr&token=UQM7NLQUXJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io)](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3277 +/- ## ========================================== - Coverage 85.06% 84.87% -0.19% ========================================== Files 1293 1306 +13 Lines 28846 29204 +358 Branches 7759 7889 +130 ========================================== + Hits 24538 24788 +250 - Misses 4308 4416 +108 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [.../src/pages/modelRegistry/screens/ModelRegistry.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FModelRegistry.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9Nb2RlbFJlZ2lzdHJ5LnRzeA==) | `100.00% <ø> (ø)` | | | [...try/screens/ModelVersions/ModelVersionListView.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FModelVersions%2FModelVersionListView.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9Nb2RlbFZlcnNpb25zL01vZGVsVmVyc2lvbkxpc3RWaWV3LnRzeA==) | `87.69% <100.00%> (+1.02%)` | :arrow_up: | | [...elRegistry/screens/ModelVersions/ModelVersions.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FModelVersions%2FModelVersions.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9Nb2RlbFZlcnNpb25zL01vZGVsVmVyc2lvbnMudHN4) | `100.00% <ø> (ø)` | | | [...reens/RegisteredModels/RegisteredModelListView.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelRegistry%2Fscreens%2FRegisteredModels%2FRegisteredModelListView.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsUmVnaXN0cnkvc2NyZWVucy9SZWdpc3RlcmVkTW9kZWxzL1JlZ2lzdGVyZWRNb2RlbExpc3RWaWV3LnRzeA==) | `81.08% <100.00%> (+1.66%)` | :arrow_up: | ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [d5938bf...f311c83](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3277?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).
openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manaswinidas Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment