opendatahub-io / odh-dashboard

Dashboard for ODH
Apache License 2.0
28 stars 160 forks source link

fix: pvc fixes #3296

Open olavtar opened 1 day ago

olavtar commented 1 day ago

Description

PVC Name update in the servingRuntime fixes

How Has This Been Tested?

Tested locally

Test Impact

Tested both fast and slow deletion, followed by model recreation.

Request review criteria:

Self checklist (all need to be checked):

If you have UI changes:

After the PR is posted & before it merges:

openshift-ci[bot] commented 1 day ago

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (215d63d) to head (3676b10).

Files with missing lines Patch % Lines
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 4 Missing :warning:
...rc/pages/modelServing/screens/projects/nimUtils.ts 86.95% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296/graphs/tree.svg?width=650&height=150&src=pr&token=UQM7NLQUXJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io)](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ```diff @@ Coverage Diff @@ ## main #3296 +/- ## ========================================== + Coverage 84.78% 84.79% +0.01% ========================================== Files 1308 1308 Lines 29247 29256 +9 Branches 7936 7937 +1 ========================================== + Hits 24796 24809 +13 + Misses 4451 4447 -4 ``` | [Files with missing lines](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) | Coverage Δ | | |---|---|---| | [frontend/src/api/k8s/servingRuntimes.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapi%2Fk8s%2FservingRuntimes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL2FwaS9rOHMvc2VydmluZ1J1bnRpbWVzLnRz) | `98.93% <100.00%> (+4.54%)` | :arrow_up: | | [...s/projects/NIMServiceModal/NIMModelListSection.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FNIMServiceModal%2FNIMModelListSection.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL05JTVNlcnZpY2VNb2RhbC9OSU1Nb2RlbExpc3RTZWN0aW9uLnRzeA==) | `1.66% <ø> (+0.02%)` | :arrow_up: | | [...d/src/pages/modelServing/screens/projects/utils.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2Futils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL3V0aWxzLnRz) | `97.27% <100.00%> (ø)` | | | [...rc/pages/modelServing/screens/projects/nimUtils.ts](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FnimUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL25pbVV0aWxzLnRz) | `57.81% <86.95%> (+5.53%)` | :arrow_up: | | [...projects/NIMServiceModal/DeployNIMServiceModal.tsx](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?src=pr&el=tree&filepath=frontend%2Fsrc%2Fpages%2FmodelServing%2Fscreens%2Fprojects%2FNIMServiceModal%2FDeployNIMServiceModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io#diff-ZnJvbnRlbmQvc3JjL3BhZ2VzL21vZGVsU2VydmluZy9zY3JlZW5zL3Byb2plY3RzL05JTVNlcnZpY2VNb2RhbC9EZXBsb3lOSU1TZXJ2aWNlTW9kYWwudHN4) | `4.80% <0.00%> (-0.15%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Last update [215d63d...3676b10](https://app.codecov.io/gh/opendatahub-io/odh-dashboard/pull/3296?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opendatahub-io).
andrewballantyne commented 17 hours ago

/ok-to-test

openshift-ci[bot] commented 13 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewballantyne. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment