Open olavtar opened 1 day ago
Hi @olavtar. Thanks for your PR.
I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Attention: Patch coverage is 75.86207%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 84.79%. Comparing base (
215d63d
) to head (3676b10
).
Files with missing lines | Patch % | Lines |
---|---|---|
...projects/NIMServiceModal/DeployNIMServiceModal.tsx | 0.00% | 4 Missing :warning: |
...rc/pages/modelServing/screens/projects/nimUtils.ts | 86.95% | 3 Missing :warning: |
/ok-to-test
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewballantyne. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Description
PVC Name update in the servingRuntime fixes
How Has This Been Tested?
Tested locally
Test Impact
Tested both fast and slow deletion, followed by model recreation.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main