opendatahub-io / odh-s2i-project-simple

GNU General Public License v3.0
6 stars 32 forks source link

Bind "prediction.py" to /prediction #4

Open aslakknutsen opened 1 year ago

aslakknutsen commented 1 year ago

Description

README and QuickStart are referring to /prediction, not /predictions

https://github.com/opendatahub-io/odh-s2i-project-simple/blob/8a05dc1f1fa707b8b6a4d3476e1efa7e5f7ee3fb/README.md?plain=1#L106 https://github.com/opendatahub-io/odh-manifests/blob/78085dd5e4e58b1b9ce66705894cbb0c0bbf1f8c/odh-dashboard/apps/jupyter/deploy-python-model-quickstart.yaml#L72

adelton commented 1 year ago

Running

$ git grep /prediction
0_start_here.ipynb:    "!curl -X POST -H \"Content-Type: application/json\" --data '{\"data\": \"hello world\"}' http://localhost:5000/predictions\n"
0_start_here.ipynb:    "response = requests.post('http://127.0.0.1:5000/predictions', '{\"hello\":\"world\"}')\n",
2_test_flask.ipynb:    "!curl -X POST -H \"Content-Type: application/json\" --data '{\"data\": \"hello world\"}' http://localhost:5000/predictions"
2_test_flask.ipynb:    "response = requests.post('http://127.0.0.1:5000/predictions', '{\"hello\":\"world\"}')\n",
README.md:!curl -X POST -H "Content-Type: application/json" --data '{"data": "hello world"}' http://localhost:5000/prediction
README.md:!curl -X POST -H "Content-Type: application/json" --data '{"data": "hello world"}' http://rhods-project.apps.cluster/prediction
wsgi.py:@application.route('/predictions', methods=['POST'])

indicates that /predictions is used everywhere except in the README.md. So I'd just propose to fix that.

adelton commented 1 year ago

I've filed https://github.com/opendatahub-io/odh-s2i-project-simple/pull/10 now as the alternative fix.