Open akram opened 2 months ago
Hi @akram. Thanks for your PR.
I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
thanks for the PR!
I am fine with "Age" to be printed out but I would hold "Status" for a while. We have an ongoing issue https://issues.redhat.com/browse/RHOAIENG-408 which need to sort out which value to be set in the "Status" first.
maybe what you really want to add is a new field of "Created At" ?
//+kubebuilder:printcolumn:name="Created At",type=string,JSONPath=.metadata.creationTimestamp
if Age has been included before this PR
Name
and Age
are the default 2 columns that are always printed if developer doesn't set anything.
If kubebuilder:printcolumn
is added, it will add the specified column after the Name
and nothing else except what is specified by kubebuilder:printcolumn
. This is why I re-added Age
.
Age
is also the default label used to display .metadata.creationTimestamp
. If you run for example oc get pods
, you will get amongst other things, Name
and Age
.
I see for the .status
value issue. Does it prevent from displaying the value even if it is incorrect?
/ok-to-test
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jackdelahunt for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@zdtsw This is very old PR. Changes looks fine. Should we merge this PR ?
fixes https://issues.redhat.com/browse/RHOAIENG-9101
Description
Adds
status.phase
to printed colums.How Has This Been Tested?
Before:
Then:
After: