Closed bartoszmajsak closed 2 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cam-garrison, zdtsw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test opendatahub-operator-e2e
Description
Instead of performing patching of Authorino deployment as part of
PostConditions
hook, it is now aFeature
on its own.As a result, we no longer need the
ApplyManifest
mehtod for theFeature
struct. This function was created solely to apply a single manifest as anAction
and was used only for this specific use case. With the dedicated feature, a deployment patch can now be defined as a regular manifest source and included as a part of the Apply phase.How Has This Been Tested?
I tested both the upgrade path and regular deployment on ROSA (hence
serviceMesh.auth.audiences
entry in the DSCI below)Prerequisite: DSCI with Service Mesh enabled
Upgrade path
incubation
)quay.io/maistra-dev/opendatahub-operator:dev-patch-authorino-deployment-as-a-feature
)Removed
management state)Screenshot or short clip
Merge criteria