opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

chore: cleanup remove kfdef during uninstallation #1100

Closed zdtsw closed 1 month ago

zdtsw commented 2 months ago

Description

We have removed the cleanup during upgrade, not sure why this was left there during uninstallation. The function is not necessary for any new releases.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

AjayJagan commented 2 months ago

Great!! this will remove the dependency from v1 version and snyk will not complain :)

zdtsw commented 2 months ago

/retest-required

zdtsw commented 2 months ago

/retest-required

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [VaishnaviHire] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment