opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

Improve regex to accept white spaces before delimiters(release-automation) #1102

Closed AjayJagan closed 1 month ago

AjayJagan commented 2 months ago

Description

Allows regex to accept whitespace before and after the delimiter '|' because when added without a whitespace github bleeds the url and makes it redirect to a malformed URL.

JIRA: https://issues.redhat.com/browse/RHOAIENG-9630

context: https://docs.google.com/document/d/1YX0zAxkl4N6-K5t4INsBqnUAxTN0GDPWV1jn9XjkgPg/edit?disco=AAABQq9SeXI

How Has This Been Tested?

The text to test is

#Release#\n\ndata-science-pipelines-operator|https:
//github.com/opendatahub-io/data-science-pipelines-operator/tree/v2.0.1 |https://github.com/opendatahub-io/data-scienc
e-pipelines-operator/releases/tag/v2.0.1

and the code to test is https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/.github/scripts/get-release-branches.js#L22-L39 with the modified regex from the pr.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sara4994

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [Sara4994] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment