opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

Revert "chore: remove duplicated logic by function call (#1080)" #1107

Closed zdtsw closed 1 month ago

zdtsw commented 1 month ago

This reverts commit f3e6a135cb0526b4672cdd6fb23a764d32495129.

previous cleanup removed the error from component when ossm and or authorino is not installed which is causing DSC does not show error but keep reconcile on kserve this is to revert the change to keep both in DSC and DSCI do the dependent check

Description

https://issues.redhat.com/browse/RHOAIENG-9664

How Has This Been Tested?

Screenshot or short clip

Merge criteria

openshift-ci[bot] commented 1 month ago

@CFSNM: changing LGTM is restricted to collaborators

In response to [this](https://github.com/opendatahub-io/opendatahub-operator/pull/1107#pullrequestreview-2166676548): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asanzgom, CFSNM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [asanzgom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.