The current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs when trying to access inference service:
envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930 script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument #1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string`
This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as Managed(). This ensures that updating the existing filters will happen on operator upgrade or next reconcile.
How Has This Been Tested?
deploy latest incubation operator
create DSCI with Service Mesh enabled
create DSC with KServe enabled
check the content of the filter oc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml. Notice wrong syntax .remove in Lua snippet
try accessing ISVC and notice error in the ingress gateway logs
deploy operator image based on this PR
confirm logs are not showing up on the ingress gateway proxy
check the content of the filter oc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml. Notice correct/patched syntax :remove in Lua snippet
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [zdtsw]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
Description
The current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs when trying to access inference service:
This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as
Managed()
. This ensures that updating the existing filters will happen on operator upgrade or next reconcile.How Has This Been Tested?
incubation
operatoroc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml
. Notice wrong syntax.remove
in Lua snippetoc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml
. Notice correct/patched syntax:remove
in Lua snippetScreenshot or short clip
Merge criteria