opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

fix(envoy-filter): properly removes headers #1108

Closed bartoszmajsak closed 1 month ago

bartoszmajsak commented 1 month ago

Description

The current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs when trying to access inference service:

envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930  script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument #1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string`

This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as Managed(). This ensures that updating the existing filters will happen on operator upgrade or next reconcile.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment