opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

chore(lint): skips true|false for goconst #1110

Closed bartoszmajsak closed 1 month ago

bartoszmajsak commented 1 month ago

Description

As we have labels and annotations with values either true or false we often compare them in the code. This leads to complains of goconst linter about extracting these "magic words" to constants. As this are obvious values to check against there's little benefit of doing so.

This change configures goconst for golangci-lint runner to skip such cases.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment