refactor: simplifies Feature Manifests

bartoszmajsak commented 1 month ago

Description

The raw and template manifest structs differed only in their content processing methods, making it an unnecessary abstraction. This work consolidates the two implementations, reducing duplication and resulting in cleaner code.

The implementation still adheres to the convention of using a .tmpl. in the file name to indicate a template and only then process it as such.

The feature builder has been reworked from chaining ManifestLocation().Manifest in favor of composition. This not only makes the code easier to follow but also allows to potentially mix different kinds of Manifest providers.

Additionally, Applier wrapper has been introduced to handle different strategies of applying manifests to the cluster based on their types.

How Has This Been Tested?

create DSCI with Service Mesh enabled
create DSC with KServe enabled
observe the successful application of all features
- inspect the status of DSCI and DSC
- inspect the status of FeatureTrackers

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

bartoszmajsak commented 1 month ago

Thanks for taking care of it @zdtsw

zdtsw commented 1 month ago

not sure why, seems prow did not act on the latest rebase :vomiting_face:

opendatahub-io / opendatahub-operator