opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
59 stars 127 forks source link

deploy: refactor whitelisting with custom kustomize RemoverPlugin #1123

Closed zdtsw closed 1 month ago

zdtsw commented 1 month ago

Description

credits to @ykaliuta , this is a follow up work from original PR https://github.com/opendatahub-io/opendatahub-operator/pull/1026 , see detail description with additional:

https://issues.redhat.com/browse/RHOAIENG-7297

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.14.7297-1

from new image

before as default Screenshot from 2024-07-19 17-04-15

after as changed replicas Screenshot from 2024-07-19 17-05-29

Screenshot from 2024-07-19 17-08-12

from old image

before on dashboard replicas Screenshot from 2024-07-16 13-21-20

after on dashboard replicas Screenshot from 2024-07-16 13-22-14

before on dspo deployment resrouce Screenshot from 2024-07-16 13-22-37

after on dspo pod resoruce Screenshot from 2024-07-16 13-25-25

Screenshot or short clip

Merge criteria

zdtsw commented 1 month ago

we have start 2nd round of review, meanwhile i will need to so more tests on this.

zdtsw commented 1 month ago

/test opendatahub-operator-e2e

zdtsw commented 1 month ago

/test opendatahub-operator-e2e

zdtsw commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [VaishnaviHire] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment