fix: auto creation DSCI during startup

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

59 stars 127 forks source link

fix: auto creation DSCI during startup #1131

Closed zdtsw closed 1 month ago

zdtsw commented 1 month ago

revert 2110c0501ea24fb8df12d12ea682e5e483e62281
add sleep before first calling CreateWithRery on DSCI

Description

https://issues.redhat.com/browse/RHOAIENG-10065

How Has This Been Tested?

local test with auto creation enabled to mimic internal build system: quay.io/wenzhou/opendatahub-operator:2.14.1

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [VaishnaviHire] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zdtsw commented 1 month ago

/test opendatahub-operator-e2e

ykaliuta commented 1 month ago

I'll post a follow up. CreateWithRetry() should consider AlreadyExists as a non-error condition and return (it's the purpose of the function, make the object exist). It was bug in my original implementation (see description of e26100e87e53), then the callers' checks are redundant. With the current implementation there is no point in CreateWithRetry().

ykaliuta commented 1 month ago

I'll post a follow up. CreateWithRetry() should consider AlreadyExists as a non-error condition and return (it's the purpose of the function, make the object exist). It was bug in my original implementation (see description of e26100e), then the callers' checks are redundant. With the current implementation there is no point in CreateWithRetry().

Here it is https://github.com/opendatahub-io/opendatahub-operator/pull/1145 .