opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations
https://opendatahub.io
Apache License 2.0
60 stars 139 forks source link

fix: devFlags for dashboard did not set correct values #1136

Closed zdtsw closed 3 months ago

zdtsw commented 3 months ago

Description

https://issues.redhat.com/browse/RHOAIENG-10276

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.15.10276

when DSC set to:

    dashboard:
      managementState: Managed

params.env is

admin_groups=odh-admins
odh-dashboard-image=<cpaas image>
dashboard-url=https://odh-dashboard-opendatahub.apps.rosa.wen-rosa-6.kuuz.p3.openshiftapps.com
section-title=OpenShift Open Data Hub

When DSC set to:

    dashboard:
      managementState: Managed
      devFlags:
        manifests:
          - contextDir: manifests
            uri: 'https://github.com/opendatahub-io/odh-dashboard/tarball/main'
    modelmeshserving: {}

params.env is

odh-dashboard-image=quay.io/opendatahub/odh-dashboard:main
dashboard-url=https://odh-dashboard-opendatahub.apps.rosa.wen-rosa-6.kuuz.p3.openshiftapps.com
section-title=OpenShift Open Data Hub
admin_groups=odh-admins

Screenshot or short clip

Merge criteria

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment