fix: when delete DSCI CR get stuck because the current instance updated and not preperly remove finalizer on it

zdtsw commented 3 months ago

Description

For investigation in https://issues.redhat.com/browse/RHOAIENG-10300 we can identify the problem is from an updated DSCI before removing finalizer. To unblock this problem in regression, this is just a workaround. and we need a proper work as suggested in https://issues.redhat.com/browse/RHOAIENG-10300

Current change:

after remove servicemesh and update condition, instance has been updated
use retryonconflict to make sure it is removed when something else might also update DSCI at the same time

https://issues.redhat.com/browse/RHOAIENG-9606

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator-catalog:v2.15.1-9096 test step:

remove ossm from cluster
create dsci and dsc cr
wait tiil "missing ossm" error in both
delete dsc cr
delete dsci cr
done

also verified in QE cluster

Screenshot or short clip

Merge criteria

[ ] You have read the contributors guide.
[ ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[ ] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM, lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/OWNERS)~~ [CFSNM,lburgazzoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

CFSNM commented 3 months ago

/retest

opendatahub-io / opendatahub-operator